Bug #795: mod_ssi (apparently) won't echo variables set using #set - Lighttpd - lighty labs

Actions

Copy link

Bug #795

closed

mod_ssi (apparently) won't echo variables set using #set

Added by Anonymous over 17 years ago. Updated almost 8 years ago.

Status:

Obsolete

Priority:

Normal

Category:

mod_ssi

Target version:

1.5.0

ASK QUESTIONS IN Forums:

Description

With the sample SSI document:

Result: "(none)"

Expected result: "bar"

Files

Download all files

mod_ssi-echo-int-var.patch (647 Bytes) mod_ssi-echo-int-var.patch	Patch which works for me	Anonymous, 2006-08-02 12:24
mod_ssi-echo-ssi-var-1.5.0svn2299.patch (680 Bytes) mod_ssi-echo-ssi-var-1.5.0svn2299.patch	-- gw.lighttpd	Anonymous, 2008-08-31 19:26
mod_ssi-recursion-ssi-vars-fix-1.5.0svn2299.patch (1005 Bytes) mod_ssi-recursion-ssi-vars-fix-1.5.0svn2299.patch	And another patch against 1.5.0-svn r2299 if you also have ticket:536 (nested requests/recursive include) -- gw.lighttpd	Anonymous, 2008-08-31 20:04
mod_ssi_echo-ssi-var_1.5.0svn2299.patch (778 Bytes) mod_ssi_echo-ssi-var_1.5.0svn2299.patch	Shorter version	Anonymous, 2008-09-02 16:13

Actions

Copy link

Updated by Anonymous over 15 years ago

I confirm that this patch is so trivial it just works! Therefore I've appended the patch against 1.5-svn revision 2299.

Actions

Copy link

Updated by Anonymous over 15 years ago

Ignore my previous patch mod_ssi-recursion-ssi-vars-fix-1.5.0svn2299.patch, because it is wrong!

First of all it looks like a hack and second it doesn't work right if you have multiple layers of nested requests. A correct implementation of a patch for making SSI variables be interpreted right in nested requests/recursive includes is in ticket:536 (apply both patches if you want SSI to work more as expected).

And also the mod_ssi-echo-ssi-var-1.5.0svn2299.patch could be written a little shorter/better: http://gw.tnode.com/0036-LighttpdDevelopment/Files-Patches/

-- gw.lighttpd

Actions

Copy link

Updated by gstrauss about 8 years ago

Description updated (diff)
Target version set to 1.5.0

Moving ticket to Target version 1.5.0

In the 1.4.x branch, this was fixed in:

commit d8e028e06900b781bebfe2f52cc7254444a31716
Author: fbrosson <fbrosson@users.noreply.github.com>
Date:   Sun Jan 3 14:48:07 2016 +0000

    [mod_ssi] enhance support for ssi vars

    Try ssi_vars if ssi_cgi_env does not have a matching var name.
    Allow var names to also include digits after the initial letter or underscore.

    From: fbrosson <fbrosson@users.noreply.github.com>

    git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@3069 152afb58-edef-0310-8abb-c4023f1b3aa9

Actions

Copy link