Ticket #738 (closed defect: fixed)

Opened 2 years ago

Last modified 7 months ago

Cache of conditional configuration tests is too eager: Breaks HTTP["url"] if conditions evaluated at uri_raw time

Reported by: lionel@… Owned by: jan
Priority: normal Milestone:
Component: core Version: 1.4.11
Severity: major Keywords:
Cc: webmaster@… Blocked By:
Need User Feedback: no Blocking:

Description

If any module runs at uri_raw time and causes the conditional configuration tests to be evaluated, they get cached. But the URL is not yet known at this time (the URL gets compared to an _empty_ string), so the cached answer is _wrong_ and HTTPurl? conditional configuration snippets don't work.

I've disabled the cache completely (replace the test in config_check_cond_cached by "if (-1)") and now it works fine.

Attachments

Change History

Changed 2 years ago by moo

HTTPurl? cannot contain any other type of conditionals, nor url.rewrite. if we do url.rewrite on cleaned url, it should workarround the problem. but this is a question to be or not to be.

Changed 7 months ago by stbuehler

  • status changed from new to closed
  • resolution set to fixed
  • pending unset

Fixed in [2080], see #1164

Add/Change #738 (Cache of conditional configuration tests is too eager: Breaks HTTP["url"] if conditions evaluated at uri_raw time)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.