Ticket #735 (new defect)

Opened 2 years ago

Last modified 2 years ago

mod_cml crash due to missing etag (on If-None-Match requests)

Reported by: dg Assigned to: jan
Priority: normal Milestone:
Component: mod_cml Version: 1.4.11
Severity: critical Keywords:
Cc: Blocking:
Need Feedback:

Description

When If-None-Match is specified and mod_cml gets a cache hit it will not populate the con->physical.etag field leading to a null pointer dereference (in http_response_handle_cachable).

I fixed this by adding (around line 407 of mod_cml_lua.c): 

   buffer_copy_string(con->physical.etag, "unknown");

Which works as mod_cml doesn't attempt to send an etag but really it needs to generate etags and handle them properly.

Attachments

Add/Change #735 (mod_cml crash due to missing etag (on If-None-Match requests))




Change Properties