Lighttpd

Debugging a module of my own, I encountered a problem that several config parameters of type int were being corrupted in a reproducible way. The problem, as it seems, lies with passing numeric values in and out of arrays. When, in a SETDEFAULTS_FUNC, values are inserted from a config context in a plugin config, this eventually results in the following statement (config-glue.c, rev. 510 line 78, or rev. 1102 line 90, in function config_insert_values_internal):

*((unsigned short *)(cv[i].destination)) = di->value;

The minimal test case is as follows:

#include <stdio.h>
#include <stdlib.h>
#include "array.h" /* From lighttpd */

void set(void *dest, data_unset *du) {
  *((unsigned short *)dest) = ((data_integer*)du)->value;
}

int main(int argc, char *argv[]) {
  int flags = 3000;
  int rcp;
  data_integer *di;

  di = data_integer_init();
  di->value = flags;
  set(&rcp, (data_unset*) di);
  printf("%d = %x\n%d = %x\n", flags, flags, rcp, rcp);
}

When compiled and run on my primary machine, which is a PowerPC, this prints:

3000 = bb8
196608000 = bb80000

I assume that this is due to PPC's being a big-endian architecture, but altogether, casting pointer types for variebyte data is somewhat careless. I have solved the problem locally by adding a new config_values_type_t value T_CONFIG_INT and a corresponding case in config_insert_values_internal. I worked with the version of lighttpd from DarwinPorts, which is no longer current, and the modification is trivial, but if you are interested in my patches anyway, please tell where to send them.

Thank you.

-- boris.smilga