Ticket #219 (new enhancement)

Opened 3 years ago

Last modified 1 month ago

New option: include_glob

Reported by: Aaron Walker <ka0ttic@gentoo.org> Assigned to: jan
Priority: normal Milestone:
Component: core Version:
Severity: normal Keywords:
Cc: Blocking:
Need Feedback: 0

Description

Attached is a patch that adds an "include_glob" directive whose argument is a glob pattern for allowing such things as: 

include_glob "extra/*.conf"

I originally patched it so that the include directive interprets it's argument as a glob pattern, but this is probably undesirable as something like 'include "foo"' will load anything with "foo" in the name.

Attachments

lighttpd-1.4.0-include_glob.diff (4.7 kB) - added by Aaron Walker <ka0ttic@gentoo.org> on 08/22/2005 12:08:58 PM.
lighttpd-1.4.1-include_glob.diff (6.1 kB) - added by Aaron Walker <ka0ttic@gentoo.org> on 08/24/2005 01:36:47 PM.

Change History

08/22/2005 12:08:58 PM changed by Aaron Walker <ka0ttic@gentoo.org>

  • attachment lighttpd-1.4.0-include_glob.diff added.

08/24/2005 01:36:13 PM changed by Aaron Walker <ka0ttic@gentoo.org>

Attaching an updated diff. Basically I added "don't parse this config if it's been parsed already" logic to make it a little more user-friendly.

Otherwise something like: 

include_glob "*.conf"

will attempt to parse the config it is currently parsing (if it ends in .conf of course), giving already defined errors once it encountered a variable/option it has already parsed.

08/24/2005 01:36:47 PM changed by Aaron Walker <ka0ttic@gentoo.org>

  • attachment lighttpd-1.4.1-include_glob.diff added.

06/12/2008 12:37:16 AM changed by anonymous

  • blocking changed.
  • pending changed.

Please add include_glob to 1.4 and 1.5 ASAP, as it is preferable to use included config files to add sites to an existing lighttpd running in a massive webfarm than it is to edit the main lighttpd.conf on all of those servers. Without include_glob, we will have to edit the main lighttpd.conf. With include_glob, we only have to add a file to /usr/local/etc/lighttpd directory and restart lighttpd. This is much better for site stability and rollbacks in massively scaled environments. If we have include_glob at our disposal, we can simply create websites as lighttpd config include files that get put into /usr/local/etc/lighttpd/, and have those files pushed out/installed as packages, like rpm or freebsd tbz, or whatever package system your OS uses. This would make things so much easier for sysadmins.

thanks!

06/12/2008 01:04:36 AM changed by anonymous

yeah yeah .... if you would have rtfm you would have found include_shell

include_shell = "cat /etc/lighttpd/vhosts.d/*.conf"

feature implemented. done.

Add/Change #219 (New option: include_glob)




Change Properties