Bug #1774

lighttpd memory leak on duplicated request header

Added by qhy 62 days ago. Updated 61 days ago.

Status:Fixed Start:
Priority:High Due date:
Assigned to:- % Done:

0%
Category:core
Target version:1.4.20
Pending:

No

 Resolution:

fixed

Description

http_request_parse function of request.c just return 0 without free previous allocated data_string when duplicated request header found.

it causes memory leak

lighttpd-1.4.19.memory.leak.patch - patch to resolve memory leak (2.2 KB) qhy, 09/20/2008 12:17 PM

History

09/20/2008 01:48 PM - stbuehler

  • Status changed from New to Fixed
  • Resolution set to fixed

Good catch! fixed in r2305

Used


array_insert_unique(con->request.headers, (data_unset *)ds);

instead of


ds->free((data_unset*)ds);

to reuse memory and save us the malloc/free calls.

Also available in: Atom PDF