Ticket #1644 (closed defect: fixed)
Large HTTP Posts - get corrupted or just hang - with fastcgi PHP
| Reported by: | eth@… | Owned by: | jan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.4.20 |
| Component: | core | Version: | 1.4.19 |
| Severity: | critical | Keywords: | |
| Cc: | Blocked By: | ||
| Need User Feedback: | no | Blocking: |
Description
Description:
I use Freebsd 7.0 with lighttpd 1.4.19 and php-cgi 5.2.5 (with suhosin patch). I run php-cgi with a external spawner.
I noticed, that when I do a large upload (1.2 megabytes) php works unadequately: randomly it either corrupts the upload or just freezes.
So for instance, if I run php-cgi on a tcp port (1026) it successfully accepts all uploads that are given to it from lighttpd and processes them through the script. But randomly (sometimes several times in a row, sometimes one out of 10 requests) it receives corrupted post data (several bytes in the center of the 1.2 megabyte block get corrupted - replaced with 00 00 00 hex values). Nothing freezes at this configuration.
If I run php-cgi as a unix socket (/tmp/php.sock) it either accepts the upload (and never shows any sign of corruption, all data is processed normally), or just halts and leaves the connection open (doesn't reply to the current and any new connections either). Sometimes it just unfreezes after a while and starts accepting new connections, sometimes I just have to respawn php-cgi.
My best guess is that it might have something to do with the freebsd 7.0 socket handling. Maybe not - maybe it really is a bug in php-cgi or lighttpd.
Reproduce code:
Here is the command I use to make the upload from the remote host.
curl -vv -# -s -F "testfile=@…" -H "Host: upload.host.ru" -H "Expect:" -H "Content-Type:" -0 1.1.1.1:200/testupload.php
Note the empty Content-type - once I noticed the corruption, I decided to make a test and debug HTTP_RAW_POST_DATA by hand. The corruption was all the way up there.
Expected result:
The testupload.php script checks the HTTP_RAW_POST_DATA, extracts the uploaded files from mime headers and checks it's md5 value. If MD5 is incorrect, it logs the uploaded file and then I compare it to the normal sample.
Interesting thing:
When I use "truss" (like strace) and attach to the lighttpd process, all requests get to the fastcgi unix-domain socket (/tmp/php.sock) without any problems. All code gets executed correctly, no hangs or corruption.
Once I turn off truss, lighttpd starts hanging the connection on random requests.
So I suppose that somehow lighttpd is related to the data corruption. And this corruption doesn't happen when I'm attached to the lighttpd process via truss.
