Ticket #1603 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

1.5-svn - server.c - fdevent_init max_fds set to 4096 instead of srv->max_fds

Reported by: complexero Assigned to: jan
Priority: normal Milestone: 1.5.0
Component: core Version: 1.5.x-svn
Severity: normal Keywords: fdevent max_fds
Cc: mike@complexero.com Blocking:
Need Feedback: 0

Description

I tried digging thru the various changesets for this line to see why the srv->max_fds was commented out in the trunk version (1.5). I checked the 1.4.x branch and that is still in place.

Can anyone shed some light as to why this was changed in the 1.5 version to 4096?

Does this limit the amount of traffic under load?

Maybe this was just missed when moved over from the 1.4.x branch.

http://trac.lighttpd.net/trac/browser/trunk/src/server.c?rev=2110 

1612         if (NULL == (srv->ev = fdevent_init(/*srv->max_fds + 1*/ 4096, srv->event_handler))) { 
1613                 log_error_write(srv, __FILE__, __LINE__, 
1614                                 "s", "fdevent_init failed"); 
1615                 return -1; 
1616         }

Attachments

Change History

03/21/2008 02:51:03 PM changed by stbuehler

  • status changed from new to closed.
  • resolution set to fixed.
  • pending deleted.

Fixed in [2132].

Add/Change #1603 (1.5-svn - server.c - fdevent_init max_fds set to 4096 instead of srv->max_fds)




Change Properties
Action