Ticket #1512 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

mod_deflate: filesize check is too weak, move to new logstyle

Reported by: stbuehler Owned by: glen
Priority: normal Milestone: 1.5.0
Component: mod_deflate Version: 1.5.x-svn
Severity: normal Keywords: patch
Cc: Blocked By:
Need User Feedback: yes Blocking:

Description

I changed the filesize check to check for the end of the file, not the current offset (abs_offset):

-       if (abs_offset > sce->st.st_size) {
+       if (c->file.length + c->file.start > sce->st.st_size) {

And i replaced the log_error_write calls with ERROR(...).

Attachments

1512.patch.gz (4.0 kB) - added by glen 7 months ago.
attach to trac

Change History

Changed 8 months ago by stbuehler

I'd really liked to add an attachment, but i got

Submission rejected as potential spam (IP *.*.*.* blacklisted by sc.surbl.org, SpamBayes determined spam probability of 0.00%, Content contained blacklisted patterns)

Changed 8 months ago by stbuehler

  • type changed from enhancement to defect

Changed 8 months ago by glen

  • pending set

403 Forbidden - Unknown commit object

Changed 8 months ago by anonymous

Yeah, sry. As i keep rebasing to the trunk, history and therefore commit ids are changing.

Current (i will tag them somehow so they won't vanish again):
http://repo.or.cz/w/lighttpd.git?a=commitdiff;h=68a2a5758854492d56d547fb691883bb01d61865[[BR]] http://repo.or.cz/w/lighttpd.git?a=commitdiff_plain;h=68a2a5758854492d56d547fb691883bb01d61865[[BR]]

Changed 7 months ago by glen

  • owner changed from jakabosky to glen
  • status changed from new to assigned

damn. i lost it again :) i will next time download it before new commits

Changed 7 months ago by anonymous

This time the Trac WikiFormatting got me (i didn't pull yet ;-)).

http://repo.or.cz/w/lighttpd.git?a=commitdiff;h=68a2a5758854492d56d547fb691883bb01d61865

http://repo.or.cz/w/lighttpd.git?a=commitdiff_plain;h=68a2a5758854492d56d547fb691883bb01d61865

So next try, with preview and link testing ;-)

(It would be cool to be able to edit ticket comments, i just forget to preview every time)

Changed 7 months ago by glen

attach to trac

Changed 7 months ago by glen

  • keywords patch added
  • status changed from assigned to closed
  • resolution set to fixed

Committed revision [2055]

Add/Change #1512 (mod_deflate: filesize check is too weak, move to new logstyle)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.