Ticket #1510 (closed defect: fixed)

Opened 8 months ago

Last modified 8 months ago

Weird things in chunk.c (functions only handling specific cases, unexpected behaviour)

Reported by: stbuehler Owned by: glen
Priority: normal Milestone: 1.5.0
Component: core Version: 1.5.x-svn
Severity: normal Keywords: chunk,filter,patch
Cc: Blocked By:
Need User Feedback: no Blocking:

Description

I wrote my own filter, and stumbled across some weird things... - offset in chunks is used inconsistently (steal_cunks) - chunkqueue_steal_chunk only worked with MEM_CHUNKs - chunkqueue_append_mem(chunkqueue *cq, const char * mem, size_t len) copied only len-1 bytes.

The following patch tries to fix this; as the existing code expected the last problem, i had to change other files as well. While i did this i started to use CONST_STR_LEN in the fixed code, so it should be more readable too.

Attachments

02-fix_chunks.patch (10.9 kB) - added by stbuehler 8 months ago.

Change History

Changed 8 months ago by stbuehler

Changed 8 months ago by stbuehler

  • keywords chunk,filter,patch added; chunk,filter removed

Changed 8 months ago by glen

  • owner changed from jan to glen

Changed 8 months ago by glen

  • status changed from new to closed
  • resolution set to fixed

Committed revision [2033].

Add/Change #1510 (Weird things in chunk.c (functions only handling specific cases, unexpected behaviour))

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.