Ticket #1320 (assigned defect)

Opened 1 year ago

Last modified 11 months ago

check return value of calloc in mod_simple_vhost.c

Reported by: Safari Assigned to: jan (accepted)
Priority: normal Milestone: 1.4.20
Component: core Version: 1.4.16
Severity: normal Keywords:
Cc: ralf@stormbind.net Blocking:
Need Feedback: 1

Attachments

mod_simple_vhost-calloc-return-value-checks.patch (1.0 kB) - added by Safari on 08/23/2007 01:46:09 PM.

Change History

08/23/2007 01:46:09 PM changed by Safari

  • attachment mod_simple_vhost-calloc-return-value-checks.patch added.

08/23/2007 02:56:33 PM changed by ralf

  • cc set to ralf@stormbind.net.
  • version changed from 1.4.15 to 1.4.16.
  • pending set to 1.
  • milestone changed from 1.5.0 to 1.4.17.

this problem affects more calls to malloc(and friends).

08/23/2007 04:28:44 PM changed by jan

  • status changed from new to assigned.

just put assert() around it and let it die. We can't handle it graceful anyway.

The buffer.c code already does that.

(follow-up: ↓ 4 ) 08/27/2007 08:26:51 PM changed by Olaf van der Spek

just put assert() around it and let it die.

Is assert supposed to be used like that? I don't think so.

(in reply to: ↑ 3 ) 08/28/2007 07:40:16 AM changed by ralf

Replying to Olaf van der Spek:

just put assert() around it and let it die.

Is assert supposed to be used like that? I don't think so.

"The assert() macro may be removed at compile time with the cc(1) option -DNDEBUG."

Add/Change #1320 (check return value of calloc in mod_simple_vhost.c)




Change Properties