Ticket #1310 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

ifdef for prctl is checking wrong constant

Reported by: ethan@plaxo.com Assigned to: jan
Priority: normal Milestone: 1.4.17
Component: core Version: 1.4.16
Severity: normal Keywords:
Cc: Blocking:
Need Feedback: 0

Description

In 1.4.16, and possibly earlier, the constant in config.h for prctl was renamed to HAVE_SYS_PRCTL_H, but server.c is not checking it correctly on line 763 to see if it should use prctl to set PR_SET_DUMPABLE. Any server running in drop-privs mode, will not be able to dump core even with server.enable-cores set. 

--- server.c    2007-06-15 08:30:34.000000000 -0700
+++ server.c.new        2007-08-21 13:54:00.000000000 -0700
@@ -760,7 +760,7 @@
                        setuid(pwd->pw_uid);
                }
 #endif
-#ifdef HAVE_PRCTL
+#ifdef HAVE_SYS_PRCTL_H
                if (srv->srvconf.enable_cores) {
                        prctl(PR_SET_DUMPABLE, 1, 0, 0, 0);
                }

Attachments

Change History

08/21/2007 11:35:18 PM changed by jan

  • status changed from new to closed.
  • resolution set to fixed.
  • milestone changed from 1.5.0 to 1.4.17.

fixed in [1958]

08/21/2007 11:37:54 PM changed by jan

and in [1961] in 1.5.0

Add/Change #1310 (ifdef for prctl is checking wrong constant)




Change Properties
Action