Ticket #1267 (closed defect: fixed)

Opened 10 months ago

Last modified 9 months ago

Inappropriate font choice in HTML-output from mod_dirlisting

Reported by: rasmus Assigned to: jan
Priority: normal Milestone: 1.5.0
Component: mod_dirlisting Version: 1.5.x-svn
Severity: trivial Keywords: html css typography formatting output
Cc: Blocking:
Need Feedback: 0

Description (Last modified by jan)

"Courier New", Courier, monospace

should be

monospace

Specifying monospace will cause the client browser to chose the most appropriate font for monospace (often chosen by the user). Explicitly specifying a certain typeface will override the users choice.

So, the HTML/CSS output should be adjusted not to override the users' settings.

My suggestion is to update mod_dirlisting.c to generate this css instead:

a, a:active {text-decoration: none; color: blue;}
a:visited {color: #48468F;}
a:hover, a:focus {text-decoration: underline; color: red;}
h2 {margin-bottom: .6em;}
table {margin-left: .7em;}
th, td { font-family: monospace; text-align: left;}
th { font-weight: bold; padding-right: 1.2em; padding-bottom: .4em;}
td {padding-right: 1.2em;}
td.s, th.s {text-align: right;}
div.list { border-top: 1px solid #999; border-bottom: 1px solid #999; padding-top: .6em; padding-bottom: 1em;}
div.foot { font-family: monospace; font-size: 90%; color: #777; padding-top: .5em;}

That would allow for respecting user configuration, be easily printable and zoom as expected in web browsers that support it.[

Attachments

lighttpd_index_font_size.patch (0.7 kB) - added by xxv on 08/11/2007 02:47:40 PM.
font size / font face directory index patch

Change History

08/11/2007 02:47:40 PM changed by xxv

  • attachment lighttpd_index_font_size.patch added.

font size / font face directory index patch

08/11/2007 02:51:37 PM changed by xxv

I added a patch that applies this change and also uses the user's default font sizes. "pt" sizes are inappropriate for text intended to be read on a screen, as points are a physical units of measure akin to inches.

08/11/2007 02:57:45 PM changed by rasmus

Great!

08/13/2007 09:51:45 AM changed by jan

  • status changed from new to closed.
  • version changed from 1.4.15 to 1.5.x-svn.
  • resolution set to fixed.
  • description changed.
  • milestone set to 1.5.0.

applied in [1897] for 1.5.0.


Add/Change #1267 (Inappropriate font choice in HTML-output from mod_dirlisting)




Change Properties
Action