Feature #1221

support *(wild card character) within include directive

Added by joungkyun 580 days ago. Updated 89 days ago.

Status:Wontfix Start:
Priority:Normal Due date:
Assigned to:- % Done:

0%

Category:core
Target version:1.4.20
Pending:

No

Resolution:

wontfix

Patch available:


Description

This patch support to use *(wild card character)within include directive.
For example:

include "conf.d/*.conf"

If you upper configration, and file not exists "conf.d/*.conf" or directory is not exists, lighttpd pass with no error messages.

lighttpd-1.4.15-include-glob.patch (3.5 KB) joungkyun, 06/07/2007 08:57 AM

History

06/12/2007 04:33 PM - darix


include_shell "cat conf.d/*conf" 

that is not enough?

06/12/2007 04:46 PM - joungkyun

Replying to darix:

{{{ include_shell "cat conf.d/*conf" }}}

that is not enough?

Yes, not enough. I think that include_shell is not definite, and I need no error when conf.d/*.conf files not found.

04/16/2008 06:53 AM - Anonymous

This is really needed so that web application packages (rpm/dpkg/whatever) can put a file containing their configuration details in the conf.d directory and have it picked up by the web server automatically.

-- DavidDick

04/19/2008 12:25 PM - stbuehler

If the directory may be not containing files matching the mask, you just need to write a script instead of using cat.

04/19/2008 06:32 PM - joungkyun

Replying to stbuehler:

If the directory may be not containing files matching the mask, you just need to write a script instead of using cat.

First, sorry for my poor english.

I thinks that this is only developer's mind. As a system engienneer, include shell is very discomfort on trouble shooting. It's not clean. If I have situation of other system trouble shooting that is not mine, I will check user define scripts. And if this scripts has very dirty code, maybe I will forgive. :-)

As a sysstem engineer, I want to be removed include_shell option. :-) Almost of lighttpd users is not developer, and they have not skill of trouble shoot themselves.

So, I think that there is other way instead of include_shell, must use other way. include_shell is the only option for a geek.

On this case, I want to say deep discussion. But I stop this thread cause of my poor english. :-(

04/19/2008 07:12 PM - stbuehler

To search the directory conf.d for *.conf files and include them you could use this:


include_shell "find conf.d -maxdepth 1 -name '*.conf' -exec cat {} \;" 

And i disagree: if you cannot code such simple scripts, you should not be a server admin (at least not on a server which needs this feature).

I don't say that we don't want this feature - but applying such a patch needs time, and there are many more imporant things on my todo list.

Btw: The debian guys coded a perl script to include "enabled" modules as apache does.

And many people got problems as they used this system. It may be good for apache, but i wouldn't recommend it with lighttpd.

04/19/2008 07:33 PM - joungkyun

Replying to stbuehler:

And i disagree: if you cannot code such simple scripts, you should not be a server admin (at least not on a server which needs this feature).

So, I said that is only developer's mind. There is so many servers that have no server admin. I don't agree yours, too.

But, I agree that this patch is useless on lighttpd. And I don't want to fix it official tree with this patch. On case that need this patch, anybody use this patch.

This patch is for somebody who need this patch for their some case.

This is difference of a point of view between you and me. I think that you are not wrong and I'm not wrong.

09/23/2008 06:30 PM - stbuehler

  • Status changed from New to Fixed
  • Resolution set to wontfix

As we agree we don't need it upstream, i close this.

10/10/2008 07:05 PM - stbuehler

  • Status changed from Fixed to Wontfix

Also available in: Atom PDF