Changeset 437

Timestamp:

07/11/2005 10:58:27 AM (3 years ago)

Author:

jan

Message:

one character was not compared for the string-length was below sizeof(size_t)

Files:

• branches/lighttpd-1.3.x/src/buffer.c (modified) (2 diffs)

branches/lighttpd-1.3.x/src/buffer.c

@@ -518 +518 @@
         if (a->used == 0) return 1;
 
-        for (i = a->used - 1; i < a->used && i % (sizeof(size_t)); i --) {
+        /* we are unsigned, if i < 0 it will flip to MAX_SIZE_T and will be > a->used */
+        for (i = a->used - 1; i < a->used && i % (sizeof(size_t)); i--) {
                 if (a->ptr[i] != b->ptr[i]) return 0;
         }
+        
+        /* compare the single char itself which was kicked us out of the loop */ 
+        if (i < a->used && a->ptr[i] != b->ptr[i]) return 0;
         
         for (i -= (sizeof(size_t)); i < a->used; i -= (sizeof(size_t))) {
@@ -526 +530 @@
                     *((size_t *)(b->ptr + i))) return 0;
         }
-
+        
         return 1;
 }