Changeset 2026

Timestamp:

11/23/2007 03:23:35 PM (8 months ago)

Author:

jan

Message:

fixed case-sensitive match of auth-method (fixes #1456)

Files:

• branches/lighttpd-1.4.x/NEWS (modified) (1 diff)
• branches/lighttpd-1.4.x/src/mod_auth.c (modified) (2 diffs)
• branches/lighttpd-1.4.x/tests/mod-auth.t (modified) (2 diffs)

branches/lighttpd-1.4.x/NEWS

@@ -9 +9 @@
-  * added support for matching $HTTP["scheme"] in configs
-  * fixed initgroups() called after chroot (#1384)
+  * fixed case-sensitive check for Auth-Method (#1456)
-  * execute fcgi app without /bin/sh if used as argument to spawn-fcgi (#1428)
-

branches/lighttpd-1.4.x/src/mod_auth.c

@@ -239 +239 @@
-
-                        if ((auth_type_len == 5) &&
-
+asec
-
-                                if (0 == strcmp(method->value->ptr, "basic")) {
@@ -245 +245 @@
-                                }
-                        } else if ((auth_type_len == 6) &&
-
+asec
-                                if (0 == strcmp(method->value->ptr, "digest")) {
-                                        if (-1 == (auth_satisfied = http_auth_digest_check(srv, con, p, req, con->uri.path, auth_realm+1))) {

branches/lighttpd-1.4.x/tests/mod-auth.t

@@ -9 +9 @@
-use strict;
-use IO::Socket;
-3
+4
-use LightyTest;
-
@@ -48 +48 @@
-$t->{RESPONSE} = [ { 'HTTP-Protocol' => 'HTTP/1.0', 'HTTP-Status' => 200 } ];
-ok($tf->handle_http($t) == 0, 'Basic-Auth: Valid Auth-token - htpasswd (des)');
+
+$t->{REQUEST}  = ( <<EOF
+GET /server-config HTTP/1.0
+Host: auth-htpasswd.example.org
+Authorization: basic ZGVzOmRlcw==
+EOF
+ );
+$t->{RESPONSE} = [ { 'HTTP-Protocol' => 'HTTP/1.0', 'HTTP-Status' => 200 } ];
+ok($tf->handle_http($t) == 0, 'Basic-Auth: Valid Auth-token - htpasswd (des) (lowercase)');
+
-
-SKIP: {