Changeset 1916

Show
Ignore:
Timestamp:
08/15/2007 11:47:05 AM (1 year ago)
Author:
jan
Message:

added a sentinel around NULL in exec() (merged from [1872] from 1.4.x,
fixes #1235)

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/NEWS

    r1914 r1916  
    1717  * fixed conditional dir-listing.exclude (#930) 
    1818  * fixed CONTENT_LENGTH = -1 in mod_cgi (#1276) 
     19  * fixed typecast of NULL on execl() (#1235) 
    1920 
    2021- 1.4.14 - ??? 

  • trunk/src/mod_accesslog.c

    r1653 r1916  
    494494                                 */ 
    495495 
    496                                 execl("/bin/sh", "sh", "-c", s->access_logfile->ptr + 1, NULL); 
     496                                execl("/bin/sh", "sh", "-c", s->access_logfile->ptr + 1, (char *)NULL); 
    497497 
    498498                                log_error_write(srv, __FILE__, __LINE__, "sss", 

  • trunk/src/mod_ssi.c

    r1827 r1916  
    708708                        close(STDIN_FILENO); 
    709709 
    710                         execl("/bin/sh", "sh", "-c", cmd, NULL); 
     710                        execl("/bin/sh", "sh", "-c", cmd, (char *)NULL); 
    711711 
    712712                        /* */ 

  • trunk/src/proc_open.c

    r1349 r1916  
    256256                proc_close_parents(proc); 
    257257 
    258                 execl(shell, shell, "-c", command, NULL); 
     258                execl(shell, shell, "-c", command, (char *)NULL); 
    259259                _exit(127); 
    260260 

  • trunk/src/spawn-fcgi.c

    r1866 r1916  
    191191 
    192192                                /* exec the cgi */ 
    193                                 execl("/bin/sh", "sh", "-c", b, NULL); 
     193                                execl("/bin/sh", "sh", "-c", b, (char *)NULL); 
    194194 
    195195                                exit(errno);